WIP: chore: Make the security-scan log path safe per job #55
No reviewers
Labels
No labels
priority/P0
priority/P1
priority/P2
priority/P3
size/L
size/M
size/S
size/XL
size/XS
state/blocked
state/done
state/in-progress
state/in-review
state/needs-refinement
state/ready
type/bug
type/chore
type/feature
type/refactor
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
amtronics/platform-actions!55
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/33-per-job-log-path"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Issue
Refs #33 (Closes on the final head)
Problem
The action writes a fixed /tmp/security-scan.log; whether that is safe depends on the runner's filesystem model, which is untested — exactly the reason the issue exists.
Solution
Evidence first: this WIP opens with a temporary probe in validate that prints runner.temp, RUNNER_TEMP, the job's container identity and /tmp's mount — the runner answers criteria 1 and 2 in its own log. The path change follows the evidence and the probe commit is dropped before the PR leaves WIP.
Review notes
Hold review until the probe is gone and the real change is in place.
Risks and trade-offs
None while WIP; the probe writes one marker file to the job's /tmp.
Closing unmerged: the probe this PR existed to run answered the question — /tmp is per-job on this runner and runner.temp expands to /tmp exactly, so no path change is warranted. Findings recorded on #33.
Pull request closed