feat: Default openbao-fetch addr to bao.internal #104

Merged

ahmad merged 1 commit from feature/103-bao-internal-default into main

2026-10-15 22:20:10 +00:00

ahmad commented

2026-10-15 22:16:05 +00:00

Owner

Issue

Closes #103

Problem

Every caller passes the vault IP as a required input, so moving OpenBao (amtronics/infrastructure-vps#548) edits 50 workflows in 17 repositories.

Solution

addr is optional and defaults to https://bao.internal:8200, which both runners resolve on the host and in job containers (amtronics/infrastructure-vps#551). An explicit addr still overrides; an empty one fails with a clear message (new behaviour test). README, CONFIGURATION and the release template drop the literal.

Review notes

No caller changes behaviour: all 50 pass addr today. The pilot repo (suhba/rihla) drops it next.

Risks and trade-offs

A runner without the bao.internal mapping fails a caller that omits addr; both current runners have it.

### Issue Closes #103 ### Problem Every caller passes the vault IP as a required input, so moving OpenBao (amtronics/infrastructure-vps#548) edits 50 workflows in 17 repositories. ### Solution `addr` is optional and defaults to `https://bao.internal:8200`, which both runners resolve on the host and in job containers (amtronics/infrastructure-vps#551). An explicit `addr` still overrides; an empty one fails with a clear message (new behaviour test). README, CONFIGURATION and the release template drop the literal. ### Review notes No caller changes behaviour: all 50 pass `addr` today. The pilot repo (suhba/rihla) drops it next. ### Risks and trade-offs A runner without the `bao.internal` mapping fails a caller that omits `addr`; both current runners have it.

ahmad added 1 commit

2026-10-15 22:16:05 +00:00

feat: Default openbao-fetch addr to bao.internal

PR / validate (pull_request) Successful in 35s

Details

32139d524e

addr becomes optional with the vault's stable name as default, so a
vault move no longer edits every caller. An explicit addr still wins;
an empty one fails loudly.

Closes #103

ahmad_bot approved these changes

2026-10-15 22:19:22 +00:00

ahmad_bot left a comment

Verified at 32139d5 (CI green: harness tests, behaviour tests, README lint):

addr is required: false with default https://bao.internal:8200; OB_ADDR still maps inputs.addr, so a passed value wins (#103 AC1, AC2).
An explicit empty addr bypasses the action default, and the new guard fails before any curl with addr is empty; omit it to use the default; the behaviour test drives exactly that path (AC3).
No caller changes behaviour: the four template steps drop the literal, README and CONFIGURATION describe the default.
Both runners resolve bao.internal on the host and in job containers (read back for amtronics/infrastructure-vps#551), so the default is reachable where this action runs.

Verified at 32139d5 (CI green: harness tests, behaviour tests, README lint): - `addr` is `required: false` with default `https://bao.internal:8200`; `OB_ADDR` still maps `inputs.addr`, so a passed value wins (#103 AC1, AC2). - An explicit empty `addr` bypasses the action default, and the new guard fails before any curl with `addr is empty; omit it to use the default`; the behaviour test drives exactly that path (AC3). - No caller changes behaviour: the four template steps drop the literal, README and CONFIGURATION describe the default. - Both runners resolve `bao.internal` on the host and in job containers (read back for amtronics/infrastructure-vps#551), so the default is reachable where this action runs.

ahmad merged commit a9f4c5f17e into main

2026-10-15 22:20:10 +00:00

ahmad deleted branch feature/103-bao-internal-default

2026-10-15 22:20:10 +00:00

ahmad referenced this pull request from a commit

2026-10-15 22:20:11 +00:00

feat: Default openbao-fetch addr to bao.internal (#104)